Remove vendored copy of ipaddress #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready_for_review |
tadeboro
approved these changes
Oct 6, 2021
webknjaz
reviewed
Oct 6, 2021
Such IPs are no longer accepted by ipaddress in Python's standard library (CVE-2021-29921).
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
felixfontein
force-pushed
the
remove-ipaddress
branch
from
85d025d to
16c0b97
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For 2.0.0, we should remove the vendored ipaddress copy. It's included in the stdlib of Python 3, and is also a dependency of older cryptography versions (which did not require Python 3).
ISSUE TYPE
COMPONENT NAME
ipaddress compat module_utils